Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8290207: Missing notice in dom.md #138

Closed
wants to merge 1 commit into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Jul 13, 2022

Update dom.md, adding notice.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.org/jdk19 pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/138.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2022

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 13, 2022
@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2022

Webrevs

@@ -1,5 +1,20 @@
## DOM Level 3 Core Specification v1.0

### W3C Software Notice
<pre>
Copy link
Member

@naotoj naotoj Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a markdown, should this be three back-ticks "```" instead of "pre" HTML tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iris can probably comment on this. It's been the pre tag across the existing md files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre tag is supported for code blocks by most markdown implementations so this should be OK and as Joe mentions has been there for ages in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think the pre tag will be fine in this instance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290207: Missing notice in dom.md

Reviewed-by: iris, lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2022
@@ -1,5 +1,20 @@
## DOM Level 3 Core Specification v1.0

### W3C Software Notice
<pre>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre tag is supported for code blocks by most markdown implementations so this should be OK and as Joe mentions has been there for ages in this file.

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

Going to push as commit 73b83e0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2022
@openjdk openjdk bot closed this Jul 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2022
@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@JoeWang-Java Pushed as commit 73b83e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8290207 branch July 13, 2022 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants