Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19 Public archive

8288397: AArch64: Fix register issues in SVE backend match rules #17

Closed
wants to merge 1 commit into from

Conversation

XiaohongGong
Copy link

@XiaohongGong XiaohongGong commented Jun 15, 2022

There are register usage issues in the sve backend match rules, which made the two added jtreg tests fail.

The predicated vector "not" rules didn't use the same register for "src" and "dst", which is necessary to make sure the inactive lanes in "dst" save the same elements as "src". This patch fixes the rules by using the same register for "dst" and "src".

And the input idx register in "gatherL/scatterL" rules was overwritten by the first unpack instruction. The same issue also existed in the partial and predicated gatherL/scatterL rules. This patch fixes them by saving the unpack results into a temp register and use it as the index for gather/scatter.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288397: AArch64: Fix register issues in SVE backend match rules

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/jdk19 pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/17.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2022

👋 Welcome back xgong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 15, 2022
@XiaohongGong
Copy link
Author

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@XiaohongGong
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 15, 2022

Webrevs

Copy link

@nsjian nsjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@XiaohongGong
Copy link
Author

Thanks for the review @nsjian !

@XiaohongGong
Copy link
Author

Hi @nick-arm, may I have your review for this PR? Thanks for your time!

@mlbridge
Copy link

mlbridge bot commented Jun 17, 2022

Mailing list message from Kandu, Rahul on hotspot-compiler-dev:

-----Original Message-----
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.org> On Behalf Of Xiaohong Gong
Sent: Thursday, June 16, 2022 6:28 PM
To: hotspot-compiler-dev at openjdk.org
Subject: Re: RFR: 8288397: AArch64: Fix register issues in SVE backend match rules

On Wed, 15 Jun 2022 09:40:52 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

There are register usage issues in the sve backend match rules, which made the two added jtreg tests fail.

The predicated vector "`not`" rules didn't use the same register for "`src`" and "`dst`", which is necessary to make sure the inactive lanes in "`dst`" save the same elements as "`src`". This patch fixes the rules by using the same register for "`dst`" and "`src`".

And the input idx register in "`gatherL/scatterL`" rules was overwritten by the first unpack instruction. The same issue also existed in the partial and predicated gatherL/scatterL rules. This patch fixes them by saving the unpack results into a temp register and use it as the index for gather/scatter.

Hi @nick-arm, may I have your review for this PR? Thanks for your time!

-------------

PR: https://git.openjdk.org/jdk19/pull/17

Copy link
Contributor

@nick-arm nick-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@XiaohongGong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288397: AArch64: Fix register issues in SVE backend match rules

Reviewed-by: njian, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 53bf1bf: 8286176: Add JNI_VERSION_19 to jni.h and JNI spec
  • c254c9d: 8287401: jpackage tests failing on Windows due to powershell issue
  • ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
  • 729164f: 8288533: Missing @param tags in com.sun.source classes
  • 9254e12: 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
  • 395aea3: 8288414: Long::compress/expand samples are not correct
  • f3b1f60: 8288289: Preview APIs in jdk.jdi, jdk.management, and jdk.jfr should be reflective preview APIs
  • 31bc689: 8288324: Loom: Uninitialized JvmtiEnvs in VM_Virtual* ops

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2022

Mailing list message from Kandu, Rahul on hotspot-compiler-dev:

-----Original Message-----
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.org> On Behalf Of Nick Gasson
Sent: Friday, June 17, 2022 5:36 AM
To: hotspot-compiler-dev at openjdk.org
Subject: Re: RFR: 8288397: AArch64: Fix register issues in SVE backend match rules

On Wed, 15 Jun 2022 09:40:52 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

There are register usage issues in the sve backend match rules, which made the two added jtreg tests fail.

The predicated vector "`not`" rules didn't use the same register for "`src`" and "`dst`", which is necessary to make sure the inactive lanes in "`dst`" save the same elements as "`src`". This patch fixes the rules by using the same register for "`dst`" and "`src`".

And the input idx register in "`gatherL/scatterL`" rules was overwritten by the first unpack instruction. The same issue also existed in the partial and predicated gatherL/scatterL rules. This patch fixes them by saving the unpack results into a temp register and use it as the index for gather/scatter.

Seems fine.

-------------

Marked as reviewed by ngasson (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/17

@XiaohongGong
Copy link
Author

Thanks for the review @nick-arm !

@XiaohongGong
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

Going to push as commit ae030bc.
Since your change was applied there have been 11 commits pushed to the master branch:

  • f12d044: 8288692: jdk/javadoc/doclet/testTagMisuse/TestTagMisuse.java fails after JDK-8288545
  • 97544be: 8268398: 15% increase in JFR footprint in Noop-Base
  • 983f75c: 8288545: Missing space in error message
  • 53bf1bf: 8286176: Add JNI_VERSION_19 to jni.h and JNI spec
  • c254c9d: 8287401: jpackage tests failing on Windows due to powershell issue
  • ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
  • 729164f: 8288533: Missing @param tags in com.sun.source classes
  • 9254e12: 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
  • 395aea3: 8288414: Long::compress/expand samples are not correct
  • f3b1f60: 8288289: Preview APIs in jdk.jdi, jdk.management, and jdk.jfr should be reflective preview APIs
  • ... and 1 more: https://git.openjdk.org/jdk19/compare/50f99c3208fc9f479cc109fb6e73d262e27026a2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2022
@openjdk openjdk bot closed this Jun 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@XiaohongGong Pushed as commit ae030bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XiaohongGong XiaohongGong deleted the JDK-8288397 branch June 20, 2022 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants