8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"

[pron]

Please review the following fix.

Detection of a deoptimized frame in thaw was incorrect, as it tested the deoptimization state of a frame object constructed without relevant data.

Passes loom tiers 1-5.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Patricio Chilano Mateo (@pchilano - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/jdk19 pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/18.diff

[bridgekeeper]

👋 Welcome back rpressler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pron The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[sspitsyn]

Nice discovery! It looks good to me.
I hope, the test does not fail with this fix anymore.
Thanks,
Serguei

[openjdk]

@pron This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"

Reviewed-by: sspitsyn, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• e26d3b3: 8288497: add support for JavaThread::is_oop_safe()
• c74a923: 8288531: Empty spans in mobile navigation markup
• af05139: 8288467: remove memory_operand assert for spilled instructions
• b9c3966: 8288671: Problematic fix for font boosting
• 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
• 33d0363: 8288741: JFR: Change package name of snippet files
• 0408f9c: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
• 1cf83a4: 8287800: JFR: Incorrect error message when starting recording with missing .jfc file
• 09da87c: 8288485: jni/nullCaller/NullCallerTest.java failing (ppc64)
• ed714af: 8288564: C2: LShiftLNode::Ideal produces wrong result after JDK-8278114
• ... and 16 more: https://git.openjdk.org/jdk19/compare/53ef59c40253d893b8624ab54092d4ddb0966695...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sspitsyn, @pchilano) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (6334d39b)

[pchilano]

LGTM.

[pron]

/integrate

[openjdk]

@pron
Your change (at version 6334d39) is now ready to be sponsored by a Committer.

[sspitsyn]

/sponsor

[openjdk]

Going to push as commit 198cec9.
Since your change was applied there have been 29 commits pushed to the master branch:

• 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
• 31d981e: 8288532: additional review changes for JDK-8286830
• a144988: 8288139: JavaThread touches oop after GC barrier is detached
• e26d3b3: 8288497: add support for JavaThread::is_oop_safe()
• c74a923: 8288531: Empty spans in mobile navigation markup
• af05139: 8288467: remove memory_operand assert for spilled instructions
• b9c3966: 8288671: Problematic fix for font boosting
• 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
• 33d0363: 8288741: JFR: Change package name of snippet files
• 0408f9c: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
• ... and 19 more: https://git.openjdk.org/jdk19/compare/53ef59c40253d893b8624ab54092d4ddb0966695...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn @pron Pushed as commit 198cec9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.