-
Notifications
You must be signed in to change notification settings - Fork 59
JDK-8288545: Missing space in error message #30
JDK-8288545: Missing space in error message #30
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 983f75c.
Your commit was automatically rebased without conflicts. |
@jonathan-gibbons Pushed as commit 983f75c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a minor update to fix the content of an error message.
As reported in JBS, the problem was partly that there was a missing space to separate two items, but also, the second item should not have been there anyway.
The fix here, for 19, is to suppress the second item. Fixing the missing space will be part of a follow-up cleanup in mainline, that is too big to include here.
Note: there is no attempt in this fix to address whether the message should be generated at all.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/30/head:pull/30
$ git checkout pull/30
Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/jdk19 pull/30/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30
View PR using the GUI difftool:
$ git pr show -t 30
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/30.diff