-
Notifications
You must be signed in to change notification settings - Fork 59
JDK-8288692: jdk/javadoc/doclet/testTagMisuse/TestTagMisuse.java fails after JDK-8288545 #37
JDK-8288692: jdk/javadoc/doclet/testTagMisuse/TestTagMisuse.java fails after JDK-8288545 #37
Conversation
…s after JDK-8288545
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming it passes tier1, looks good.
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
For later. I would be surprised if this could ever happen:
|
/integrate |
@jonathan-gibbons Pushed as commit f12d044. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a simple fix to address an NPE that can occur with a bad (empty)
{@link}
tag.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/37/head:pull/37
$ git checkout pull/37
Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.org/jdk19 pull/37/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 37
View PR using the GUI difftool:
$ git pr show -t 37
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/37.diff