Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19 Public archive

8288528: broken links in java.desktop #44

Closed
wants to merge 5 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Jun 20, 2022

doccheck reports some broken links which are rectified. copyright year updated for files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/44/head:pull/44
$ git checkout pull/44

Update a local copy of the PR:
$ git checkout pull/44
$ git pull https://git.openjdk.org/jdk19 pull/44/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 44

View PR using the GUI difftool:
$ git pr show -t 44

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/44.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jun 20, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

Hi @kumarabhi006, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kumarabhi006" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title 8288528: broken links in java.desktop 8288528: broken links in java.desktop Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 20, 2022
@kumarabhi006
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jun 20, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@prrace
Copy link

prrace commented Jun 21, 2022

"doccheck reports some broken links which are rectified"

That's a bit terse.
First this version owes a lot to what was discussed in the initial PR : https://git.openjdk.org/jdk/pull/9195
Second: please add an evaluation about these points in the bug report.

Third: there's no spec issue here so we don't need a CSR.

Copy link

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that "make docs" is happy and looks good.

@prrace
Copy link

prrace commented Jun 21, 2022

This isn't actually "rfr" yet because of the lack of OCA verification.

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the copyright year be updated?

@@ -32,8 +32,8 @@
* A class representing the tags found in an Exif IFD. Exif is a
* standard for annotating images used by most digital camera
* manufacturers. The Exif specification may be found at
* <a href="http://www.exif.org/Exif2-2.PDF">
* {@code http://www.exif.org/Exif2-2.PDF}
*<a href="https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd preserve the space between * and < as it was before.

@aivanov-jdk
Copy link
Member

Should the copyright year be updated?

This applies to all the files, not only ExifTIFFTagSet.java.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288528: broken links in java.desktop

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
  • 1f9521e: 8287076: Document.normalizeDocument() produces different results
  • a716f79: 8288589: Files.readString ignores encoding errors for UTF-16
  • 4c9ea7e: 8286580: serviceability/jvmti/vthread/GetSetLocalTest failed with assert: Not supported for heap frames
  • 3f5e48a: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small
  • 6458ebc: 8288988: ProblemList serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java in -Xcomp mode
  • 6037ccd: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
  • 8fa46c8: 8288840: StructureViolationException should not link to fork method
  • 7cf71bc: 8287982: Concurrent implicit attach from native threads crashes VM
  • 9e2d9ac: 8288529: broken link in java.xml
  • ... and 17 more: https://git.openjdk.org/jdk19/compare/ae030bcbc53fdfcfb748ae1e47e660f698b3fcb7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2022

Webrevs

@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@kumarabhi006
Your change (at version e1f6cef) is now ready to be sponsored by a Committer.

@prsadhuk
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

Going to push as commit b0db333.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
  • 1f9521e: 8287076: Document.normalizeDocument() produces different results
  • a716f79: 8288589: Files.readString ignores encoding errors for UTF-16
  • 4c9ea7e: 8286580: serviceability/jvmti/vthread/GetSetLocalTest failed with assert: Not supported for heap frames
  • 3f5e48a: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small
  • 6458ebc: 8288988: ProblemList serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java in -Xcomp mode
  • 6037ccd: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
  • 8fa46c8: 8288840: StructureViolationException should not link to fork method
  • 7cf71bc: 8287982: Concurrent implicit attach from native threads crashes VM
  • 9e2d9ac: 8288529: broken link in java.xml
  • ... and 17 more: https://git.openjdk.org/jdk19/compare/ae030bcbc53fdfcfb748ae1e47e660f698b3fcb7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2022
@openjdk openjdk bot closed this Jun 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@prsadhuk @kumarabhi006 Pushed as commit b0db333.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants