8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0

[mcimadamore]

The various SegmentAllocator subclasses do not check for the constraints mentioned in the javadoc.
This patch pulls the checks into a common routine in the Utils class, and then call that check routine from all the allocate implementations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/jdk19 pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/50.diff

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cf1422b3)

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• e26d3b3: 8288497: add support for JavaThread::is_oop_safe()
• c74a923: 8288531: Empty spans in mobile navigation markup
• af05139: 8288467: remove memory_operand assert for spilled instructions
• b9c3966: 8288671: Problematic fix for font boosting
• 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
• 33d0363: 8288741: JFR: Change package name of snippet files
• 0408f9c: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
• 1cf83a4: 8287800: JFR: Incorrect error message when starting recording with missing .jfc file
• 09da87c: 8288485: jni/nullCaller/NullCallerTest.java failing (ppc64)
• ed714af: 8288564: C2: LShiftLNode::Ideal produces wrong result after JDK-8278114
• ... and 4 more: https://git.openjdk.org/jdk19/compare/53bf1bfdabb79b37afedd09051d057f9eea620f2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit d7b43af.
Since your change was applied there have been 19 commits pushed to the master branch:

• 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
• 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
• 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
• 31d981e: 8288532: additional review changes for JDK-8286830
• a144988: 8288139: JavaThread touches oop after GC barrier is detached
• e26d3b3: 8288497: add support for JavaThread::is_oop_safe()
• c74a923: 8288531: Empty spans in mobile navigation markup
• af05139: 8288467: remove memory_operand assert for spilled instructions
• b9c3966: 8288671: Problematic fix for font boosting
• 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
• ... and 9 more: https://git.openjdk.org/jdk19/compare/53bf1bfdabb79b37afedd09051d057f9eea620f2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit d7b43af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.