8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

[reinrich]

Increment LIR_OpVisitState::maxNumberOfOperands by 1 to allow C1 compilation of a method that receives 21 parameters in registers instead of crashing.

Add regression test. The regression test crashes on ppc because there all parameters (8 integer + 13 float = 21) can be passed in registers.

The fix passed our CI testing. This includes most JCK and JTREG test, also in Xcomp mode, on the standard platforms and also on Linux/PPC64le.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/51/head:pull/51
$ git checkout pull/51

Update a local copy of the PR:
$ git checkout pull/51
$ git pull https://git.openjdk.org/jdk19 pull/51/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 51

View PR using the GUI difftool:
$ git pr show -t 51

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/51.diff

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3e3774c0)

[shipilev]

Looks fine. Last time this was bumped in JDK-8004051, and there seem to be no recorded regressions for that bump.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Reviewed-by: shade, mdoerr, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 9e2d9ac: 8288529: broken link in java.xml
• 70008da: 8287971: Throw exception for missing values in .jpackage.xml
• d7b43af: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0
• 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
• 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
• 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
• 31d981e: 8288532: additional review changes for JDK-8286830
• a144988: 8288139: JavaThread touches oop after GC barrier is detached
• e26d3b3: 8288497: add support for JavaThread::is_oop_safe()
• c74a923: 8288531: Empty spans in mobile navigation markup
• ... and 1 more: https://git.openjdk.org/jdk19/compare/b9c396625cc3fcddb89f93255f85f73a931acc34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

Thanks for fixing it and providing a test. LGTM.

[TobiHartmann]

Looks good.

[reinrich]

Thanks for the review!
/integrate

[openjdk]

Going to push as commit 3f5e48a.
Since your change was applied there have been 15 commits pushed to the master branch:

• 6458ebc: 8288988: ProblemList serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java in -Xcomp mode
• 6037ccd: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
• 8fa46c8: 8288840: StructureViolationException should not link to fork method
• 7cf71bc: 8287982: Concurrent implicit attach from native threads crashes VM
• 9e2d9ac: 8288529: broken link in java.xml
• 70008da: 8287971: Throw exception for missing values in .jpackage.xml
• d7b43af: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0
• 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
• 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
• 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
• ... and 5 more: https://git.openjdk.org/jdk19/compare/b9c396625cc3fcddb89f93255f85f73a931acc34...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 3f5e48a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.