-
Notifications
You must be signed in to change notification settings - Fork 59
8288840: StructureViolationException should not link to fork method #52
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add core-libs |
@AlanBateman |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8fa46c8.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit 8fa46c8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
StructureViolationException has a
@see
link to a fork method that does not throw this exception. The link should be removed for JDK 19. We'll add the link back once the JEP for Extent-Local Variables is integrated.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/52/head:pull/52
$ git checkout pull/52
Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/jdk19 pull/52/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 52
View PR using the GUI difftool:
$ git pr show -t 52
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/52.diff