Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19 Public archive

8289093: BlockLocationPrinter fails to decode addresses with G1 #68

Closed

Conversation

tschatzl
Copy link

@tschatzl tschatzl commented Jun 24, 2022

Hi all,

can I have reviews for this change that fixes an assertion failure when trying to add annotations to the hs_err file?

The block_start API from CollectedHeap assumes that useful values for all given addresses is returned, not asserting/crashing like some method deeper in the call chain does since JDK-8270540, resulting in somewhat scrambled hs_err files and additional stack frames to look at in the debugger.

Testing: local compilation, gha, tier1-3

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289093: BlockLocationPrinter fails to decode addresses with G1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/68/head:pull/68
$ git checkout pull/68

Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.org/jdk19 pull/68/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 68

View PR using the GUI difftool:
$ git pr show -t 68

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/68.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8289093 8289093: BlockLocationPrinter fails to decode addresses with G1 Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 24, 2022
@tschatzl tschatzl marked this pull request as ready for review June 24, 2022 18:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289093: BlockLocationPrinter fails to decode addresses with G1

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
  • 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2022
@tschatzl
Copy link
Author

Thanks @albertnetymk @walulyai for your reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit 699ad45.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 784a0f0: 8288683: C2: And node gets wrong type due to not adding it back to the worklist in CCP
  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
  • 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@tschatzl Pushed as commit 699ad45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8289093-blocklocationprinter branch August 10, 2022 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants