8289228: SegmentAllocator::allocateArray null handling is too lax

[mcimadamore]

Recent fix for JDK-8289188 relaxed behavior or SegmentAllocator::allocateArray too much w.r.t. nulls. This patch reverts null handling to what it used to be.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289228: SegmentAllocator::allocateArray null handling is too lax

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)
• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.org/jdk19 pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/76.diff

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (db170f14)
• 00: Full (0bbf661b)

[JornVernee]

Should test/jdk/java/foreign/TestNulls.java also be reverted?

[mcimadamore]

Should test/jdk/java/foreign/TestNulls.java also be reverted?

Yes, I thought I did that, but the changes got reverted by the merge I did. Re-added the changes now.

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289228: SegmentAllocator::allocateArray null handling is too lax

Reviewed-by: jvernee, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 2efa89a: 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java
• 17ef8ca: 8288524: Allow @systemProperty to appear in overview documentation
• caa6b74: 8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode
• 28913f4: 8289235: ProblemList vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011/TestDescription.java when run with vthread wrapper
• 7746664: 8280826: Document set of strings javac recognizes for SuppressWarnings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit adbd200.
Since your change was applied there have been 6 commits pushed to the master branch:

• b449038: 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding
• 2efa89a: 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java
• 17ef8ca: 8288524: Allow @systemProperty to appear in overview documentation
• caa6b74: 8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode
• 28913f4: 8289235: ProblemList vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011/TestDescription.java when run with vthread wrapper
• 7746664: 8280826: Document set of strings javac recognizes for SuppressWarnings

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit adbd200.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.