Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19 Public archive

8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM #91

Closed
wants to merge 6 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Jun 29, 2022

This patch changes all VaList implementations to throw NoSuchElementException when out of bounds reads occur on a VaList that is created using the Java builder API. The docs are updated accordingly.

For VaLists that are created from native addresses, we don't know their bounds, so we can not throw exceptions in that case.

Testing: jdk_foreign test suite on all platforms that implement VaList.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
  • JDK-8289333: Specification of method j.l.foreign.VaList::skip deserves clarification
  • JDK-8289156: j.l.foreign.VaList::skip call could throw java.lang.IndexOutOfBoundsException: Out of bound access on segment
  • JDK-8289540: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jdk19 pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/91.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 29, 2022
@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jun 30, 2022
@JornVernee
Copy link
Member Author

/solves 8289333
/solves 8289156

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@JornVernee
Adding additional issue to solves list: 8289333: Specification of method j.l.foreign.VaList::skip deserves clarification.

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@JornVernee
Adding additional issue to solves list: 8289156: j.l.foreign.VaList::skip call could throw java.lang.IndexOutOfBoundsException: Out of bound access on segment.

@JornVernee JornVernee marked this pull request as ready for review July 4, 2022 11:26
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2022

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I've added some comments, esp. in the javadoc

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
8289333: Specification of method j.l.foreign.VaList::skip deserves clarification
8289156: j.l.foreign.VaList::skip call could throw java.lang.IndexOutOfBoundsException: Out of bound access on segment

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2022
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

Going to push as commit 3164c98.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c3806b9: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions
  • 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2022
@openjdk openjdk bot closed this Jul 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@JornVernee Pushed as commit 3164c98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants