Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19u Public archive

8028265: Add legacy tz tests to OpenJDK #10

Closed

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Aug 4, 2022

Please review this PR. The PR open sources the closed timezone tests.
The fix is exact same change as the original fix. JDK-8028265


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/jdk19u pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/10.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2022

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92deab546549ca549408a983fe361d9536d2cd37 8028265: Add legacy tz tests to OpenJDK Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

This backport pull request has now been updated with issue from the original commit.

@satoyoshiki
Copy link
Author

@coffeys Can I ask you to help reviewing this PR?

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8028265: Add legacy tz tests to OpenJDK

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 11fc748: Merge
  • 54c093a: 8291524: jdk/jfr/event/runtime/TestClassLoaderStatsEvent.java Value not equal to 2, field='hiddenClassCount', value='0'
  • 1d16c91: 8291512: Snippetize modules API examples
  • 36c00fd: 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2022

Webrevs

@satoyoshiki
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@satoyoshiki
Your change (at version 6adb7a8) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Aug 4, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

Going to push as commit 4d1e9b3.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 11fc748: Merge
  • 54c093a: 8291524: jdk/jfr/event/runtime/TestClassLoaderStatsEvent.java Value not equal to 2, field='hiddenClassCount', value='0'
  • 1d16c91: 8291512: Snippetize modules API examples
  • 36c00fd: 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2022
@openjdk openjdk bot closed this Aug 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@coffeys @satoyoshiki Pushed as commit 4d1e9b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants