8292487: Back out the fix forJDK-8281962 from jdk19u

[LanceAndersen]

Hi,

Please review this PR which reverts the fix for JDK-8281962 that unfortunately introduced a regression. The fix for the regression is being addressed via JDK-8292327.

Mach5 tiers 1-3 are currently running.

The intent is to give the fix for JDK-8292327 more time to bake in the main openjdk workspace (for JDK 20) and in the meantime revert JDK-8281962 in jdk19u.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292487: Back out the fix forJDK-8281962 from jdk19u

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Volker Simonis (@simonis - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/jdk19u pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/11.diff

[bridgekeeper]

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (88461642)

[openjdk]

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292487: Back out the fix forJDK-8281962 from jdk19u

Reviewed-by: alanb, simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 5c9ba00: Merge
• 967a28c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
• 4c6d22a: 8288769: Revert unintentional change to deflate.c
• 5fce02e: 8291496: Allocating card table before heap causes underflow asserts in CardTable::addr_for()
• 0def531: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Hm, as @simonis writes here, wouldn't it make more sense to either back it out from jdk19 or to backport the fix of JDK-8292327? The first one would really play on the safe side and the latter one would help to give some more air to the regression fix.

[LanceAndersen]

Hm, as @simonis writes here, wouldn't it make more sense to either back it out from jdk19 or to backport the fix of JDK-8292327? The first one would really play on the safe side and the latter one would help to give some more air to the regression fix.

Please see openjdk/jdk#9881 (comment) for the reasoning why this PR was created and targeted for 19u

[RealCLanger]

Hm, as @simonis writes here, wouldn't it make more sense to either back it out from jdk19 or to backport the fix of JDK-8292327? The first one would really play on the safe side and the latter one would help to give some more air to the regression fix.

Please see openjdk/jdk#9881 (comment) for the reasoning why this PR was created and targeted for 19u

OK. So be it then. 😄

[simonis]

I tend to agree with @RealCLanger for the reasons outlined in my JBS comment but in the end it's your decision.

Back out looks good.

[AlanBateman]

The timing is unfortunate. If this issue has been reported a week or two earlier then we may have been able to do something for JDK 19. The 19.0.1 release is about a month after 19 GA so the regression will be short lived (assuming it gets approved for 19.0.1 of course).

[LanceAndersen]

/integrate

[openjdk]

Going to push as commit 030ff3a.
Since your change was applied there have been 5 commits pushed to the master branch:

• 5c9ba00: Merge
• 967a28c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
• 4c6d22a: 8288769: Revert unintentional change to deflate.c
• 5fce02e: 8291496: Allocating card table before heap causes underflow asserts in CardTable::addr_for()
• 0def531: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

Your commit was automatically rebased without conflicts.

[openjdk]

@LanceAndersen Pushed as commit 030ff3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.