Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

Conversation

@Deigue
Copy link
Contributor

@Deigue Deigue commented Sep 1, 2022

Backport changes from JDK-8288377


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jdk19u pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/16.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2022

👋 Welcome back Deigue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c3256414f7df049cdd6c8519fbcea0d818a1a33 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@Deigue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 673f61b: 8292654: G1 remembered set memory footprint regression after JDK-8286115
  • c77b1e0: 8293180: JQuery UI license file not updated

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2022

Webrevs

@Deigue
Copy link
Contributor Author

Deigue commented Sep 6, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 6, 2022
@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@Deigue
Your change (at version 4e33b2e) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 28, 2022

Going to push as commit a1cc5be.
Since your change was applied there have been 24 commits pushed to the master branch:

  • e102312: 8293834: Update CLDR data following tzdata 2022c update
  • 7f34799: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations"
  • 59a331a: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • 30294b3: 8286314: Trampoline not created for far runtime targets outside small CodeCache
  • d0b021b: 8288992: AArch64: CMN should be handled the same way as CMP
  • e6bd2c9: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 27158f2: 8290451: Incorrect result when switching to C2 OSR compilation from C1
  • 83cb884: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 63c53da: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 6b9fe5d: 8293044: C1: Missing access check on non-accessible class
  • ... and 14 more: https://git.openjdk.org/jdk19u/compare/d10e902ad899a2908acc0f196b720768160644ff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2022
@openjdk openjdk bot closed this Sep 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 28, 2022
@openjdk
Copy link

openjdk bot commented Sep 28, 2022

@RealCLanger @Deigue Pushed as commit a1cc5be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants