8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub

[VladimirKempik]

Please review this backport to jdk19u.
This fixes critical error in call_stub in risc-v
APplies almost clean. Slightly different class names in surrounding code ( in vmreg_riscv.cpp ) prevents it being clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub

Reviewers

• Fei Yang (@RealFYang - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk19u pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/19.diff

[bridgekeeper]

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (06f46b57)

[RealFYang]

Looks good to me. (Not a JDK Updates Reviewer)

[VladimirKempik]

The scara thinks the backport is clean, great. I will update once some testing finished

[VladimirKempik]

Testing in good on hifive.

[VladimirKempik]

/integrate

[openjdk]

Going to push as commit 66bc356.
Since your change was applied there have been 5 commits pushed to the master branch:

• 903c21b: 8292051: jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java failed "AssertionError: Expected terminated values: [666] but got: []"
• 5d304f5: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
• 0c71773: 8292240: CarrierThread.blocking not reset when spare not activated
• 2070269: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName
• c6a8536: 8292579: (tz) Update Timezone Data to 2022c

Your commit was automatically rebased without conflicts.

[openjdk]

@VladimirKempik Pushed as commit 66bc356.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.