Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19u Public archive

8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages #27

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Sep 18, 2022

Clean backport to jdk19u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jdk19u pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/27.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2022

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8bd79d3efdcab5997056675467aac70895903d33 8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages Sep 18, 2022
@openjdk
Copy link

openjdk bot commented Sep 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 18, 2022

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 689f8f2: 8294357: (tz) Update Timezone Data to 2022d
  • e2a9916: 8292969: Bad Thread Utilization in ForkJoinPool
  • 1454bf2: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
  • 152d2f1: 8290529: C2: assert(BoolTest(btest).is_canonical()) failure
  • 3d1cabb: 8294517: Update jdk19u fix version to 19.0.2
  • a1cc5be: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable
  • e102312: 8293834: Update CLDR data following tzdata 2022c update
  • 7f34799: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations"
  • 59a331a: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • 30294b3: 8286314: Trampoline not created for far runtime targets outside small CodeCache
  • ... and 13 more: https://git.openjdk.org/jdk19u/compare/903c21b0268f7c5e3bfd3ae69328b864fb3cc65c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2022

Webrevs

@reschke
Copy link

reschke commented Sep 19, 2022

FWIW; the failing test macos-aarch64 seems to be a CI glitch.

@reschke
Copy link

reschke commented Sep 22, 2022

So, what's the next step here?

@VladimirKempik
Copy link
Author

It's to test the included testcase on any of supported systems, to make sure the patched JDK passes the test just fine

@reschke
Copy link

reschke commented Sep 22, 2022

It's to test the included testcase on any of supported systems, to make sure the patched JDK passes the test just fine

But the test is included, in the PR, no?

So the only question is why tests failed on macos-aarch64 - and that is clearly a CI problem (wget failing to download something).

@VladimirKempik
Copy link
Author

VladimirKempik commented Sep 22, 2022

It's to test the included testcase on any of supported systems, to make sure the patched JDK passes the test just fine

But the test is included, in the PR, no?

But nobody have yet run it on the patched openjdk19.
CI runs only tier1 tests, and I highly doubt this test is part of tier1.

So the only question is why tests failed on macos-aarch64 - and that is clearly a CI problem (wget failing to download something).

It's just CI problem.

@reschke
Copy link

reschke commented Sep 22, 2022

And there is no CI that will run these tests?

@VladimirKempik
Copy link
Author

And there is no CI that will run these tests?

that's right

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2022

@VladimirKempik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2022

@VladimirKempik This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants