Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region #33

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 22, 2022

Backport of JDK-8291775. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/jdk19u pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/33.diff

…ust have a region

Reviewed-by: thartmann, kvn
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 32d675ca607d341ca3428efc32e212701775e3c6 8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2022

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

Going to push as commit e8a134a.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a8ca05c: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 058507f: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 83d0573: 8292756: java.lang.AssertionError at at jdk.compiler/com.sun.tools.javac.code.Scope$ScopeImpl.leave(Scope.java:386)
  • 88490ec: 8293348: A false cyclic inheritance error reported
  • b5f7988: 8293578: Duplicate ldc generated by javac
  • 66bc356: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2022
@openjdk openjdk bot closed this Sep 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@TobiHartmann Pushed as commit e8a134a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants