Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19u Public archive

8288992: AArch64: CMN should be handled the same way as CMP #36

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 22, 2022

Backport of JDK-8288992. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288992: AArch64: CMN should be handled the same way as CMP

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jdk19u pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/36.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cc2b79270445ccfb2181894fed2edfd4518a2904 8288992: AArch64: CMN should be handled the same way as CMP Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288992: AArch64: CMN should be handled the same way as CMP

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2022

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

Going to push as commit d0b021b.
Since your change was applied there have been 12 commits pushed to the master branch:

  • e6bd2c9: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 27158f2: 8290451: Incorrect result when switching to C2 OSR compilation from C1
  • 83cb884: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 63c53da: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 6b9fe5d: 8293044: C1: Missing access check on non-accessible class
  • e8a134a: 8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region
  • a8ca05c: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 058507f: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 83d0573: 8292756: java.lang.AssertionError at at jdk.compiler/com.sun.tools.javac.code.Scope$ScopeImpl.leave(Scope.java:386)
  • 88490ec: 8293348: A false cyclic inheritance error reported
  • ... and 2 more: https://git.openjdk.org/jdk19u/compare/903c21b0268f7c5e3bfd3ae69328b864fb3cc65c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2022
@openjdk openjdk bot closed this Sep 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@TobiHartmann Pushed as commit d0b021b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant