Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8287906: Rewrite of GitHub Actions (GHA) sanity tests #4

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 11, 2022

backport JDK-8287906 - clean


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287906: Rewrite of GitHub Actions (GHA) sanity tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/jdk19u pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/4.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1a6533225d8f4b9c5d21e236eaa9f827f096fa5d 8287906: Rewrite of GitHub Actions (GHA) sanity tests Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287906: Rewrite of GitHub Actions (GHA) sanity tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 84ec6d5: 8289853: Update HarfBuzz to 4.4.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2022

Webrevs

@RealCLanger
Copy link
Contributor

Looks good. The errors observed should be fixed with:

  1. 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java which is not yet merged into jdk19u
  2. 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows - this was done only in head jdk so far, I've triggered a backport to jdk19.

@gdams
Copy link
Member Author

gdams commented Jul 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 16, 2022
@openjdk
Copy link

openjdk bot commented Jul 16, 2022

@gdams
Your change (at version c10f8ce) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 17, 2022

Going to push as commit 50f6a70.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 84ec6d5: 8289853: Update HarfBuzz to 4.4.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2022
@openjdk openjdk bot closed this Jul 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 17, 2022
@openjdk
Copy link

openjdk bot commented Jul 17, 2022

@RealCLanger @gdams Pushed as commit 50f6a70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the actions_rewrite branch July 17, 2022 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants