Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr #41

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 27, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/41/head:pull/41
$ git checkout pull/41

Update a local copy of the PR:
$ git checkout pull/41
$ git pull https://git.openjdk.org/jdk19u pull/41/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 41

View PR using the GUI difftool:
$ git pr show -t 41

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/41.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c89556f6cd4d0b64f3e9e2f1dc7c51634522f205 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Oct 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

Going to push as commit 1454bf2.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 152d2f1: 8290529: C2: assert(BoolTest(btest).is_canonical()) failure
  • 3d1cabb: 8294517: Update jdk19u fix version to 19.0.2
  • a1cc5be: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable
  • e102312: 8293834: Update CLDR data following tzdata 2022c update
  • 7f34799: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations"
  • 59a331a: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • 30294b3: 8286314: Trampoline not created for far runtime targets outside small CodeCache
  • d0b021b: 8288992: AArch64: CMN should be handled the same way as CMP
  • e6bd2c9: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 27158f2: 8290451: Incorrect result when switching to C2 OSR compilation from C1
  • ... and 7 more: https://git.openjdk.org/jdk19u/compare/88490ec1dc98a3b698e68c1b5eaee27efba24678...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2022
@openjdk openjdk bot closed this Oct 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@MBaesken Pushed as commit 1454bf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant