Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19u Public archive

8290900: Build failure with Clang 14+ due to function warning attribute #44

Closed
wants to merge 1 commit into from

Conversation

caoman
Copy link

@caoman caoman commented Oct 5, 2022

Hi all,

Could anyone review this backport of https://bugs.openjdk.org/browse/JDK-8290900? It applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290900: Build failure with Clang 14+ due to function warning attribute

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/44/head:pull/44
$ git checkout pull/44

Update a local copy of the PR:
$ git checkout pull/44
$ git pull https://git.openjdk.org/jdk19u pull/44/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 44

View PR using the GUI difftool:
$ git pr show -t 44

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/44.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2022

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2022

Webrevs

@caoman caoman changed the title 8290900: Build failure with Clang 14+ due to function warning attribute Backport 0599a05f8c7e26d4acae0b2cc805a65bdd6c6f67 Oct 6, 2022
@openjdk openjdk bot changed the title Backport 0599a05f8c7e26d4acae0b2cc805a65bdd6c6f67 8290900: Build failure with Clang 14+ due to function warning attribute Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290900: Build failure with Clang 14+ due to function warning attribute

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 689f8f2: 8294357: (tz) Update Timezone Data to 2022d

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2022
@caoman
Copy link
Author

caoman commented Oct 7, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@caoman
Your change (at version 9fd8384) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

Going to push as commit 763c080.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 689f8f2: 8294357: (tz) Update Timezone Data to 2022d

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2022
@openjdk openjdk bot closed this Oct 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@phohensee @caoman Pushed as commit 763c080.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@caoman
Copy link
Author

caoman commented Oct 7, 2022

Thank you Paul for sponsoring!

@mlbridge
Copy link

mlbridge bot commented Oct 8, 2022

Mailing list message from Man Cao on jdk-updates-dev:

Hi all,

Could anyone sponsor me to integrate this backport? See
https://github.com//pull/44.
It has been approved in https://bugs.openjdk.org/browse/JDK-8290900

-Man
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20221007/a6722f80/attachment.htm>

@caoman caoman deleted the backport-8290900 branch October 13, 2022 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants