Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

8292158: AES-CTR cipher state corruption with AVX-512 #51

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 21, 2022

Backport of JDK-8292158. Did not apply cleanly because of different files names (stubGenerator_x86_64_aes.cpp vs. macroAssembler_x86_aes.cpp). Approval is pending.

Thanks,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292158: AES-CTR cipher state corruption with AVX-512

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/51/head:pull/51
$ git checkout pull/51

Update a local copy of the PR:
$ git checkout pull/51
$ git pull https://git.openjdk.org/jdk19u pull/51/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 51

View PR using the GUI difftool:
$ git pr show -t 51

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/51.diff

Reviewed-by: kvn
Backport-of: 9d76ac8a4453bc51d9dca2ad6c60259cfb2c4203
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d76ac8a4453bc51d9dca2ad6c60259cfb2c4203 8292158: AES-CTR cipher state corruption with AVX-512 Oct 21, 2022
@openjdk
Copy link

openjdk bot commented Oct 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 21, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2022

Webrevs

Copy link

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292158: AES-CTR cipher state corruption with AVX-512

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2022
@TobiHartmann
Copy link
Member Author

Thanks, Vladimir!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit eaaf01e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 53f6f0b: 8295268: Optimized builds are broken due to incorrect assert_is_rfp shortcuts
  • 4d082b9: 8294307: ISO 4217 Amendment 173 Update
  • ea14585: 8029633: Raw inner class constructor ref should not perform diamond inference

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@TobiHartmann Pushed as commit eaaf01e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants