Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8295554: Move the "sizecalc.h" to the correct location #57

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 25, 2022

Hi all,
This pull request contains a backport of commit 6673cd85 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295554: Move the "sizecalc.h" to the correct location

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/57/head:pull/57
$ git checkout pull/57

Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jdk19u pull/57/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 57

View PR using the GUI difftool:
$ git pr show -t 57

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/57.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6673cd857722d117b108590ba7f7c02f8622fc3b 8295554: Move the "sizecalc.h" to the correct location Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295554: Move the "sizecalc.h" to the correct location

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 3bb0bc9: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 875a226: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • 41677c1: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • 25448dc: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
  • 56da7e2: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2022
@mrserb mrserb marked this pull request as ready for review October 26, 2022 06:49
@mrserb
Copy link
Member Author

mrserb commented Oct 26, 2022

@aivanov-jdk please prepare the closed part of this change

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

@aivanov-jdk
Copy link
Member

@aivanov-jdk please prepare the closed part of this change

In progress.

@aivanov-jdk
Copy link
Member

@aivanov-jdk please prepare the closed part of this change

In progress.

It is ready for integration.

@aivanov-jdk
Copy link
Member

The bug has now jdk19u-fix-yes which it means it can be integrated to 19u.

@mrserb
Copy link
Member Author

mrserb commented Nov 4, 2022

/integrate defer

@openjdk openjdk bot added the deferred label Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@mrserb Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command.

@aivanov-jdk
Copy link
Member

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 491bdee.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 3bb0bc9: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 875a226: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • 41677c1: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • 25448dc: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
  • 56da7e2: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review deferred labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@aivanov-jdk Pushed as commit 491bdee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb
Copy link
Member Author

mrserb commented Nov 4, 2022

@aivanov-jdk thank you for the help!

@aivanov-jdk
Copy link
Member

@aivanov-jdk thank you for the help!

You're very welcome, @mrserb!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants