Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

8295469: S390X: Optimized builds are broken #58

Closed
wants to merge 1 commit into from
Closed

8295469: S390X: Optimized builds are broken #58

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 25, 2022

Fixes S390X optimized builds.

Additional testing:

  • Linux S390X {fastdebug, release, slowdebug, optimized} builds

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/58/head:pull/58
$ git checkout pull/58

Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.org/jdk19u pull/58/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 58

View PR using the GUI difftool:
$ git pr show -t 58

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/58.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b2e83b3955c034208325ea5477afd3c5e1da41a 8295469: S390X: Optimized builds are broken Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295469: S390X: Optimized builds are broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 8, 2022

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit 0f76ade.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9badfe4: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
  • c6e1849: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
  • 491bdee: 8295554: Move the "sizecalc.h" to the correct location
  • 3bb0bc9: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 875a226: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • 41677c1: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • 25448dc: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
  • 56da7e2: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@shipilev Pushed as commit 0f76ade.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant