Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19u Public archive

8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing #69

Closed
wants to merge 1 commit into from

Conversation

nibjen
Copy link
Contributor

@nibjen nibjen commented Nov 16, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/69/head:pull/69
$ git checkout pull/69

Update a local copy of the PR:
$ git checkout pull/69
$ git pull https://git.openjdk.org/jdk19u pull/69/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 69

View PR using the GUI difftool:
$ git pr show -t 69

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/69.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 16, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

Hi @nibjen, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user nibjen" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

This backport pull request has now been updated with issue from the original commit.

@nibjen
Copy link
Contributor Author

nibjen commented Nov 16, 2022

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 16, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

⚠️ @nibjen the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout bug_8296480
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@nibjen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 55a239c: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
  • 647450e: 8296496: Overzealous check in sizecalc.h prevents large memory allocation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nibjen
Copy link
Contributor Author

nibjen commented Nov 18, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@nibjen
Your change (at version a8d2f1f) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Nov 18, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

Going to push as commit e8fd24d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 55a239c: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
  • 647450e: 8296496: Overzealous check in sizecalc.h prevents large memory allocation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022
@openjdk openjdk bot closed this Nov 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@coffeys @nibjen Pushed as commit e8fd24d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants