-
Notifications
You must be signed in to change notification settings - Fork 49
8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing #69
Conversation
Hi @nibjen, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user nibjen" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
This backport pull request has now been updated with issue from the original commit. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@nibjen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
/sponsor |
Going to push as commit e8fd24d.
Your commit was automatically rebased without conflicts. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/69/head:pull/69
$ git checkout pull/69
Update a local copy of the PR:
$ git checkout pull/69
$ git pull https://git.openjdk.org/jdk19u pull/69/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 69
View PR using the GUI difftool:
$ git pr show -t 69
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/69.diff