Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8296945: PublicMethodsTest is slow due to dependency verification with debug builds #80

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 22, 2022

Hi all,

This pull request contains a backport of JDK-8296945, commit bcc6b12b from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 21 Nov 2022 and was reviewed by Mandy Chung and Tobias Hartmann.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296945: PublicMethodsTest is slow due to dependency verification with debug builds

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/80/head:pull/80
$ git checkout pull/80

Update a local copy of the PR:
$ git checkout pull/80
$ git pull https://git.openjdk.org/jdk19u pull/80/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 80

View PR using the GUI difftool:
$ git pr show -t 80

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/80.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bcc6b12b711a9c5007d963123fb38a7e72aaf8e5 8296945: PublicMethodsTest is slow due to dependency verification with debug builds Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296945: PublicMethodsTest is slow due to dependency verification with debug builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

Going to push as commit a370758.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 6615c05: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
  • 793c16c: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
  • d1268e9: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
  • 6c7378a: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 3f3bbdf: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
  • 4708c7b: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency
  • 71b38e2: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • 62db7bb: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • c8082a3: 8296771: RISC-V: C2: assert(false) failed: bad AD file
  • 2adc3e1: 8295414: [Aarch64] C2: assert(false) failed: bad AD file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2022
@openjdk openjdk bot closed this Nov 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@RealCLanger Pushed as commit a370758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant