8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

[TobiHartmann]

Backport of JDK-8294538. Applies cleanly. Approval is pending.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

Reviewers

• Erik Österlund (@fisk - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/jdk19u pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/81.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (3f29850e)

[fisk]

Looks good.

[TobiHartmann]

Thanks for the review, Erik!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit d1268e9.
Since your change was applied there have been 7 commits pushed to the master branch:

• 6c7378a: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
• 3f3bbdf: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
• 4708c7b: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency
• 71b38e2: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
• 62db7bb: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
• c8082a3: 8296771: RISC-V: C2: assert(false) failed: bad AD file
• 2adc3e1: 8295414: [Aarch64] C2: assert(false) failed: bad AD file

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit d1268e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.