Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails #89

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 22, 2022

Backport for JDK-8022403 sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails

Cherry-picked from openjdk/jdk@65f7de2

Clean test backport.
Test update, low risk.
Test passed during manual run on mac and linux using cmd:
make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
There's a followup fix for this test, that will be also backported.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/89/head:pull/89
$ git checkout pull/89

Update a local copy of the PR:
$ git checkout pull/89
$ git pull https://git.openjdk.org/jdk19u pull/89/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 89

View PR using the GUI difftool:
$ git pr show -t 89

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/89.diff

…ringResizeTest.java fails

Reviewed-by: prr, psadhukhan
(cherry picked from commit 65f7de252366e30ba18a22c107fc301c0fdc9378)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 65f7de252366e30ba18a22c107fc301c0fdc9378 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • d1268e9: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
  • 6c7378a: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 3f3bbdf: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
  • 4708c7b: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency
  • 71b38e2: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • 62db7bb: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • c8082a3: 8296771: RISC-V: C2: assert(false) failed: bad AD file
  • 2adc3e1: 8295414: [Aarch64] C2: assert(false) failed: bad AD file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@Rudometov
Your change (at version 3a84688) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit 793c16c.
Since your change was applied there have been 8 commits pushed to the master branch:

  • d1268e9: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
  • 6c7378a: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 3f3bbdf: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
  • 4708c7b: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency
  • 71b38e2: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • 62db7bb: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • c8082a3: 8296771: RISC-V: C2: assert(false) failed: bad AD file
  • 2adc3e1: 8295414: [Aarch64] C2: assert(false) failed: bad AD file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@phohensee @Rudometov Pushed as commit 793c16c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
3 participants