-
Notifications
You must be signed in to change notification settings - Fork 49
8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java #90
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
Webrevs
|
/integrate |
/sponsor |
@Rudometov This pull request has not yet been marked as ready for integration. |
@phohensee The change author (@Rudometov) must issue an |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8297153
git fetch https://git.openjdk.org/jdk19u master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
/clean |
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@Rudometov Only OpenJDK Committers can use the |
…enRenderingResizeTest.java 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again Reviewed-by: serb (cherry picked from commit 3c0949824e06f2b3d44f1bde9d2292a7627b0197)
/integrate |
@Rudometov Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
@Rudometov |
/sponsor |
Going to push as commit 677a7c4.
Your commit was automatically rebased without conflicts. |
@RealCLanger @Rudometov Pushed as commit 677a7c4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for
JDK-8297153 sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again
JDK-8297241 Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
Original commit: openjdk/jdk@3c09498
Clean backport.
Fixing unstable test.
Checked on mac and linux by running:
make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java"
This PR depends on #89
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/90/head:pull/90
$ git checkout pull/90
Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.org/jdk19u pull/90/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 90
View PR using the GUI difftool:
$ git pr show -t 90
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/90.diff