Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8300055: [BACKOUT] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE #102

Closed
wants to merge 1 commit into from

Conversation

gerard-ziemski
Copy link

@gerard-ziemski gerard-ziemski commented Jan 12, 2023

This is a backout of JDK-8291060 OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE which triggered a bug in ksh, resulting in a crash.

Verified with test case from https://bugs.openjdk.org/browse/JDK-8299258 and running Mach5 hs-tier1,2,3,4,5.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300055: [BACKOUT] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.org/jdk20 pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/102.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@gerard-ziemski The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 12, 2023
@gerard-ziemski gerard-ziemski marked this pull request as ready for review January 12, 2023 20:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

Copy link

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, and a complete backout of the original change. Feel free to push.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@gerard-ziemski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300055: [BACKOUT] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

Reviewed-by: tschatzl, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
@gerard-ziemski
Copy link
Author

Thank you @tschatzl and @RogerRiggs for speedy reviews. I will integrate as soon as I get go ahead from our gatekeeper.

@gerard-ziemski
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit e008146.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2023
@openjdk openjdk bot closed this Jan 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@gerard-ziemski Pushed as commit e008146.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member

I will integrate as soon as I get go ahead from our gatekeeper.

Just FYI: You didn't need to wait for a gatekeeper to okay this. We're still in RDP1.
Even after we enter RDP2, it will be the release team that determines whether things
are approved. I do appreciate the heads up since I like to know what's going in this
late, but just an advisory is fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants