Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC #103

Closed
wants to merge 3 commits into from
Closed

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jan 13, 2023

Trivial fixes to ProblemList some tests:
JDK-8300141 ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC
JDK-8300144 ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.java with ZGC
JDK-8300147 ProblemList vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java in Xcomp


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC
  • JDK-8300144: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.java with ZGC
  • JDK-8300147: ProblemList vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java in Xcomp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.org/jdk20 pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/103.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8300141
/issue JDK-8300144
/issue JDK-8300147

/label add hotspot-runtime
/label add core-libs
/label add hotspot-gc
/label add hotspot-compiler

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8300144: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.java with ZGC.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8300147: ProblemList vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java in Xcomp.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@vidmik - Thanks for the fast review!

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC
8300144: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.java with ZGC
8300147: ProblemList vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java in Xcomp

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
@dcubed-ojdk
Copy link
Member Author

/integrate

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review January 13, 2023 22:51
@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit bc498f8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2023
@openjdk openjdk bot closed this Jan 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk Pushed as commit bc498f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@dcubed-ojdk The command integrate can only be used in open pull requests.

@mlbridge
Copy link

mlbridge bot commented Jan 13, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8300141 branch January 18, 2023 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants