Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs #107

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jan 13, 2023

This pull request contains a backport of commit b8852f65 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 9 Jan 2023 and was reviewed by Joe Wang, Naoto Sato and Lance Andersen.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.org/jdk20 pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/107.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@justin-curtis-lu The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2023

Webrevs

@justin-curtis-lu justin-curtis-lu changed the title 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs Backport b8852f65a0adcb9ee5693bb6727a0668aa9808bf Jan 13, 2023
@openjdk openjdk bot changed the title Backport b8852f65a0adcb9ee5693bb6727a0668aa9808bf 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bc498f8: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@justin-curtis-lu
Your change (at version a222426) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Jan 13, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit 87865e0.
Since your change was applied there have been 5 commits pushed to the master branch:

  • dc5cc61: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
  • 98eae6d: 8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs
  • 628266a: 8299501: Usage of constructors of primitive wrapper classes should be avoided in java.util API docs
  • ab7f43f: 8299498: Usage of constructors of primitive wrapper classes should be avoided in java.lang API docs
  • bc498f8: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2023
@openjdk openjdk bot closed this Jan 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@naotoj @justin-curtis-lu Pushed as commit 87865e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants