Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc #114

Closed
wants to merge 1 commit into from

Conversation

asotona
Copy link
Member

@asotona asotona commented Jan 24, 2023

Reviewed-by: jjg, darcy
Backport-of: 836198a4009c4a3f10a76dc8734e4792bb2509ba


Progress

  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8300740 to be approved
  • Commit message must refer to an issue

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/114/head:pull/114
$ git checkout pull/114

Update a local copy of the PR:
$ git checkout pull/114
$ git pull https://git.openjdk.org/jdk20 pull/114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 114

View PR using the GUI difftool:
$ git pr show -t 114

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/114.diff

…k.compiler module javadoc

Reviewed-by: jjg, darcy
Backport-of: 836198a4009c4a3f10a76dc8734e4792bb2509ba
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2023

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 836198a4009c4a3f10a76dc8734e4792bb2509ba 8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2023
@asotona
Copy link
Member Author

asotona commented Jan 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

Going to push as commit 60b8a98.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2023
@openjdk openjdk bot closed this Jan 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@asotona Pushed as commit 60b8a98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@asotona The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jan 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2023

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant