-
Notifications
You must be signed in to change notification settings - Fork 60
8298463: tools/javac/modules/EdgeCases.java fails on Windows after JDK-8297988 #12
Conversation
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
@lahodaj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 52fffdd.
Your commit was automatically rebased without conflicts. |
JavaFileObject.getName()
uses platform-specific name separators in the path. The test needs to normalize name separators before comparing them with expected output.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/12/head:pull/12
$ git checkout pull/12
Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/jdk20 pull/12/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12
View PR using the GUI difftool:
$ git pr show -t 12
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/12.diff