Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working #17

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 12, 2022

Hi all,
This pull request contains a backport of commit 5540a8c5 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 8 Dec 2022 and was reviewed by Prasanta Sadhukhan.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/jdk20 pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/17.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5540a8c5b7160ab5c67bb84631e3de54fa5aeceb 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • ca39eb9: 7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
  • 2c42499: 8298050: Add links to graph output for javadoc
  • 48f6127: 8298376: ZGC: thaws stackChunk with stale oops
  • 22a6b59: 8298727: Trees.getPath may crash for unnamed package
  • 323e574: 8298371: monitors_on_stack extracts unprocessed oops
  • 80cadd4: 8298785: gc/TestFullGCCount.java fails with "invalid boolean value: null' for expression vm.opt.ExplicitGCInvokesConcurrent'"
  • ebc4710: 8298277: Replace "session" with "scope" for FFM access
  • 581f9f2: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
  • 0eeaf6b: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4
  • 2791701: 8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."
  • ... and 12 more: https://git.openjdk.org/jdk20/compare/d624debe23f60d778d7be43f28d06e9454057217...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 12, 2022
@mrserb mrserb marked this pull request as ready for review December 13, 2022 19:58
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 14, 2022

@psadhukhan please take a look

@prsadhuk
Copy link
Contributor

I guess for clean backport doesn't need a reviewer..

@mrserb
Copy link
Member Author

mrserb commented Dec 15, 2022

I guess for clean backport doesn't need a reviewer.

@prrace can you please confirm that, so I can integrate

@prrace
Copy link
Contributor

prrace commented Dec 15, 2022

It requires reviewer approval
"No reviewer for a clean backport" is allowed for update release backports,
which do however require the UR maintainer to approve,
This isn't an update release. It is a feature release and there's no maintainer/lead approval required before RDP2.
This came up once before and skara marking the PR as "ready" is a bug.
Actually filing a skara bug hasn't happened but I am assured it will be done.

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I see this would have gone into 20 directly but it missed the fork by just a little bit,
and it is a backout, so approving.

@mrserb
Copy link
Member Author

mrserb commented Dec 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

Going to push as commit 03a694a.
Since your change was applied there have been 23 commits pushed to the master branch:

  • c7d7e7e: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
  • ca39eb9: 7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
  • 2c42499: 8298050: Add links to graph output for javadoc
  • 48f6127: 8298376: ZGC: thaws stackChunk with stale oops
  • 22a6b59: 8298727: Trees.getPath may crash for unnamed package
  • 323e574: 8298371: monitors_on_stack extracts unprocessed oops
  • 80cadd4: 8298785: gc/TestFullGCCount.java fails with "invalid boolean value: null' for expression vm.opt.ExplicitGCInvokesConcurrent'"
  • ebc4710: 8298277: Replace "session" with "scope" for FFM access
  • 581f9f2: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
  • 0eeaf6b: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4
  • ... and 13 more: https://git.openjdk.org/jdk20/compare/d624debe23f60d778d7be43f28d06e9454057217...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2022
@openjdk openjdk bot closed this Dec 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@mrserb Pushed as commit 03a694a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants