-
Notifications
You must be signed in to change notification settings - Fork 61
8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows #18
Conversation
…java failing on Windows
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
@jerboaa
|
@jerboaa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! /integrate |
Going to push as commit cf93933. |
Re-created the PR from https://git.openjdk.org/jdk/pull/11606 so as to get the test fixed in JDK 20. According to https://openjdk.org/jeps/3 test and documentation bugs are eligible during RDP 1 and RDP 2 provided they have a
noreg-self
label, which this bug has./cc @seanjmullan
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/18/head:pull/18
$ git checkout pull/18
Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/jdk20 pull/18/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18
View PR using the GUI difftool:
$ git pr show -t 18
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/18.diff