Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax #25

Closed
wants to merge 1 commit into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Dec 13, 2022

Hi all,

This pull request contains a backport of commit 042b7062 from the openjdk/jdk repository.

The commit being backported was authored by Axel Boldt-Christmas on 13 Dec 2022 and was reviewed by Erik Österlund, Albert Mingkun Yang and Roberto Castañeda Lozano.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/jdk20 pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/25.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2022

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 042b7062f19b313f31b228bd96d2a74cc1165ab9 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax

Reviewed-by: thartmann, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 51f0a1c: 8298527: Cygwin's uname -m returns different string than before
  • 61ab16f: 8298700: Typo in DocTree comment
  • c6f22b4: 8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive
  • bf78f71: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xmas92
Copy link
Member Author

xmas92 commented Dec 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

Going to push as commit 581f9f2.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 0eeaf6b: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4
  • 2791701: 8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."
  • 0bbc418: 8294902: Undefined Behavior in C2 regalloc with null references
  • 9bcdfc4: 8298425: System.console().readLine() hangs in jshell
  • 27d4971: 8298520: C2: assert(found_opaque == res) failed: wrong pattern
  • 51f0a1c: 8298527: Cygwin's uname -m returns different string than before
  • 61ab16f: 8298700: Typo in DocTree comment
  • c6f22b4: 8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive
  • bf78f71: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2022
@openjdk openjdk bot closed this Dec 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@xmas92 Pushed as commit 581f9f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants