Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

Conversation

@bplb
Copy link
Member

@bplb bplb commented Dec 15, 2022

Add a sentence to clarify that coding exceptions are not thrown until the characters are actually written to the underlying stream.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
  • JDK-8298609: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jdk20 pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/36.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 15, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2022
@bplb
Copy link
Member Author

bplb commented Dec 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

Going to push as commit ca39eb9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2c42499: 8298050: Add links to graph output for javadoc
  • 48f6127: 8298376: ZGC: thaws stackChunk with stale oops
  • 22a6b59: 8298727: Trees.getPath may crash for unnamed package
  • 323e574: 8298371: monitors_on_stack extracts unprocessed oops

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2022
@openjdk openjdk bot closed this Dec 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@bplb Pushed as commit ca39eb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Files-newBufferedWriter-7093322 branch December 15, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants