Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx #42

Closed
wants to merge 4 commits into from
Closed

8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx #42

wants to merge 4 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 15, 2022

A batch of trivial fixes to ProblemList tests:

JDK-8298888 ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
JDK-8298889 ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux
JDK-8298891 ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC
JDK-8298892
ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
  • JDK-8298889: ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux
  • JDK-8298891: ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC
  • JDK-8298892: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.org/jdk20 pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/42.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8298888
/issue JDK-8298889
/issue JDK-8298891
/issue JDK-8298892

/label add hotspot-runtime
/label add hotspot-gc
/label add serviceability

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 15, 2022 23:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298889: ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux.

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298891: ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC.

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
8298889: ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux
8298891: ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC
8298892: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC

Reviewed-by: bpb, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298892: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC.

@dcubed-ojdk
Copy link
Member Author

@bplb - Thanks for the fast review! I'm now waiting for the bots to catch up...

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 15, 2022

Webrevs

@dcubed-ojdk
Copy link
Member Author

@lmesnik - Thanks for the fast review!

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

Going to push as commit c7d7e7e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2022
@openjdk openjdk bot closed this Dec 16, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 16, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk Pushed as commit c7d7e7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8298888 branch December 16, 2022 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants