Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8298784: JFR: Test chunk integrity #43

Closed
wants to merge 3 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Dec 16, 2022

Could I have a review of a test that checks that constants (thread, stack trace, classes and string) are properly handled when rotating. The test currently fails, so I have added @ignore, but it can be removed once the underlying product issues have been resolved.

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.org/jdk20 pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/43.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@egahlin egahlin changed the title XXXXXXXX: Test chunk integrity 8XXXXXX: Test chunk integrity Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Dec 16, 2022
@egahlin egahlin changed the title 8XXXXXX: Test chunk integrity 8298784: JFR: Test chunk integrity Dec 16, 2022
@egahlin egahlin marked this pull request as ready for review December 16, 2022 11:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298784: JFR: Test chunk integrity

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 3410555: 8298987: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64
  • d102672: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • 41cc044: 8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java
  • 3b7970c: 8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64
  • 0ecad28: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
  • c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
  • 9e10f00: 8298919: Add a regression test for JDK-8298520
  • b14794d: 8298852: Use of uninitialized memory in MetadataFactory::free_metadata
  • f771c56: 8298797: Specification of some restricted methods is incorrect
  • 0ba4734: 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there.
  • ... and 8 more: https://git.openjdk.org/jdk20/compare/80cadd40103cf1f490a5d70be784652e27588114...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2022
@egahlin
Copy link
Member Author

egahlin commented Dec 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

Going to push as commit 3dd2cfa.
Since your change was applied there have been 24 commits pushed to the master branch:

  • ea40f29: 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepare Mixed): expected true, was false"
  • d0a7679: 4958969: ObjectOutputStream example leads to non-working code
  • f07acfc: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits
  • 3e17e3c: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus
  • 188aaef: 8277074: Qualified exported types show up in JavaDoc
  • 2c69c41: 8298894: java/lang/Thread/virtual/stress/Skynet.java timed out and threw OutOfMemoryError
  • 3410555: 8298987: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64
  • d102672: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • 41cc044: 8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java
  • 3b7970c: 8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64
  • ... and 14 more: https://git.openjdk.org/jdk20/compare/80cadd40103cf1f490a5d70be784652e27588114...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2022
@openjdk openjdk bot closed this Dec 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@egahlin Pushed as commit 3dd2cfa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants