8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display

[azvegint]

openjdk/jdk#9525 has changed behavior of PassFailJFrame.
it doesn't call setVisible() from its constructor on instruction window anymore and some tests were not ready for that.

So adding positionTestWindow() fixes the issue.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display

Reviewers

• Harshitha Onkar (@honkar-jdk - Committer) ⚠️ Review applies to 6ae5260e
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/46/head:pull/46
$ git checkout pull/46

Update a local copy of the PR:
$ git checkout pull/46
$ git pull https://git.openjdk.org/jdk20 pull/46/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 46

View PR using the GUI difftool:
$ git pr show -t 46

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/46.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (eb179ee7)
• 01: Full - Incremental (8fbac73e)
• 00: Full (6ae5260e)

[lawrence-andrew]

Looks good to me.

[honkar-jdk]

Changes look good.

[lawrence-andrew]

Can you fix the summary of "Tests if JComboBox displays correctly when editable/non-editable" of ProgressTest.java

[azvegint]

Can you fix the summary of "Tests if JComboBox displays correctly when editable/non-editable" of ProgressTest.java

Done, bug was also wrong

[lawrence-andrew]

Do you need this extra tab space?

[lawrence-andrew]

Looks good to me.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display

Reviewed-by: honkar, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 0ecad28: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
• c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
• 9e10f00: 8298919: Add a regression test for JDK-8298520

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

Going to push as commit d102672.
Since your change was applied there have been 5 commits pushed to the master branch:

• 41cc044: 8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java
• 3b7970c: 8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64
• 0ecad28: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
• c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
• 9e10f00: 8298919: Add a regression test for JDK-8298520

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit d102672.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.