8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64

[aghaisas]

The nature of data plays an important part in rendering performance as noted in the comment made on JDK-8288948 -
https://bugs.openjdk.org/browse/JDK-8288948?focusedCommentId=14504772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14504772

Although the fix JDK-8288948 is logical, it seems to have an adverse impact on SwingMark test numbers especially on aarch64.

The SwingMark tests closely depict the UI operations in real-world applications as compared to the J2DBench and RenderPerfTest tests. Hence, it is decided to revert the regression causing commits JDK-8288948 (and dependent JDK-8291266).

Metal rendering pipeline performance numbers before and after this PR are attached to the JBS.

Note : The fix for JDK-8291266 has a good regression test - DrawPrimitivesTest.java. It passes even after reverting the said changes. This test will be added back once this PR is committed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64

Reviewers

• Alexey Ushakov (@avu - Committer) ⚠️ Review applies to da8c8f50
• Phil Race (@prrace - Reviewer) ⚠️ Review applies to da8c8f50
• Jayathirth D V (@jayathirthrao - Reviewer) ⚠️ Review applies to da8c8f50

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/jdk20 pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/47.diff

[bridgekeeper]

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aghaisas The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5a4be5bc)
• 00: Full (da8c8f50)

[avu]

The rest of the code looks good

[openjdk]

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64

Reviewed-by: avu, prr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 9e10f00: 8298919: Add a regression test for JDK-8298520
• b14794d: 8298852: Use of uninitialized memory in MetadataFactory::free_metadata
• f771c56: 8298797: Specification of some restricted methods is incorrect
• 0ba4734: 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there.
• c47e64e: 8297979: ZGC: Ensure consistent MemoryUsage from MemoryMXBean.getHeapMemoryUsage()
• 03a694a: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jayathirthrao]

We should keep latest updated year. Please update it before pushing.

[aghaisas]

/integrate

[openjdk]

Going to push as commit 3b7970c.
Since your change was applied there have been 8 commits pushed to the master branch:

• 0ecad28: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
• c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
• 9e10f00: 8298919: Add a regression test for JDK-8298520
• b14794d: 8298852: Use of uninitialized memory in MetadataFactory::free_metadata
• f771c56: 8298797: Specification of some restricted methods is incorrect
• 0ba4734: 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there.
• c47e64e: 8297979: ZGC: Ensure consistent MemoryUsage from MemoryMXBean.getHeapMemoryUsage()
• 03a694a: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Your commit was automatically rebased without conflicts.

[openjdk]

@aghaisas Pushed as commit 3b7970c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.