Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java #48

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Dec 16, 2022

This test was stabilized and removed from problemlist recently.
Looks like previous efforts of improving test stability was not enough to prevent crashed of a system.
It still may crash Xserver somehow(but never in single test run), this prevents normal ATR.

So problem listing the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/48/head:pull/48
$ git checkout pull/48

Update a local copy of the PR:
$ git checkout pull/48
$ git pull https://git.openjdk.org/jdk20 pull/48/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 48

View PR using the GUI difftool:
$ git pr show -t 48

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/48.diff

@azvegint
Copy link
Member Author

/label client

@azvegint azvegint changed the title 8298970 Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java 8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java Dec 16, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@azvegint
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 17, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0ecad28: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
  • c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
  • 9e10f00: 8298919: Add a regression test for JDK-8298520

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2022
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2022

Going to push as commit 41cc044.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 3b7970c: 8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64
  • 0ecad28: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
  • c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
  • 9e10f00: 8298919: Add a regression test for JDK-8298520

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2022
@openjdk openjdk bot closed this Dec 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2022
@openjdk
Copy link

openjdk bot commented Dec 17, 2022

@azvegint Pushed as commit 41cc044.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants