Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8298893: Rename option UsePolyIntrinsics to UsePoly1305Intrinsics #49

Closed
wants to merge 2 commits into from

Conversation

vpaprotsk
Copy link
Contributor

@vpaprotsk vpaprotsk commented Dec 16, 2022

Fix for better documentation. FYI @jnimeh


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298893: Rename option UsePolyIntrinsics to UsePoly1305Intrinsics

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk20 pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/49.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2022

👋 Welcome back vpaprotsk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2022
Copy link
Member

@jnimeh jnimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. The changes look good to me.

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@vpaprotsk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@vpaprotsk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298893: Rename option UsePolyIntrinsics to UsePoly1305Intrinsics

Reviewed-by: jnimeh, chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • ea40f29: 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepare Mixed): expected true, was false"
  • d0a7679: 4958969: ObjectOutputStream example leads to non-working code
  • f07acfc: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits
  • 3e17e3c: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus
  • 188aaef: 8277074: Qualified exported types show up in JavaDoc
  • 2c69c41: 8298894: java/lang/Thread/virtual/stress/Skynet.java timed out and threw OutOfMemoryError
  • 3410555: 8298987: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64
  • d102672: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • 41cc044: 8298970: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java
  • 3b7970c: 8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64
  • ... and 9 more: https://git.openjdk.org/jdk20/compare/ca39eb906692568347e7f264520593188f9276cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jnimeh, @vnkozlov, @chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2022
@vpaprotsk
Copy link
Contributor Author

/integrate

@jnimeh
Copy link
Member

jnimeh commented Dec 16, 2022

When this is integrated I will take care of man page/doc changes for both our intrinsics. Two other items of note:

  • Please remember to update the release note with the modified name (JDK-8297970)
  • You might need to modify this issue to be a P3 bug rather than P5 RFE in order for it to get backported into JDK 20, which we want it to be.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@vpaprotsk
Your change (at version a4fadde) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Dec 16, 2022

Webrevs

@vpaprotsk
Copy link
Contributor Author

@jnimeh

  • Ah, I just noticed that @chhagedorn changed the issue overnight. Can change it back to P3 and against jdk20?
  • yep, will change the release note, thanks for the reminder

@jnimeh
Copy link
Member

jnimeh commented Dec 16, 2022

I would think you'd need to make a backport for JDK 20. Perhaps there you can set the backport to Bug/P3.

Copy link

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in RDP1 phase. Enhancement changes require approval by following process:
https://openjdk.org/jeps/3#Late-Enhancement-Request-Process

@vpaprotsk
Copy link
Contributor Author

I think there is some confusion.. I had originally opened a "bug" against jdk20 (per a discussion with Jamil). Last night the issue got switched to a P5 enhancement against dev.

So as to not add to the confusion, not going to touch the issue or the PR until someone tells me otherwise? @jnimeh @vnkozlov @chhagedorn ?

@vnkozlov
Copy link

@vpaprotsk
Such renaming is enhancement. But these changes are simple and will be approved for JDK 20.
It is easy to follow process I pointed: add label and comment to JDK-8298893. And wait approval.
Note, for documentation changes you don't need approval during RDP1.

@vpaprotsk
Copy link
Contributor Author

Added a comment and labels to the JBS issue. I think thats it, but let me know what else I've missed or what else need fixin'

@vnkozlov
Copy link

Added a comment and labels to the JBS issue. I think thats it, but let me know what else I've missed or what else need fixin'

Good. We have to wait when Mark approve it or delegate.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpaprotsk Such renaming is enhancement. But these changes are simple and will be approved for JDK 20. It is easy to follow process I pointed: add label and comment to JDK-8298893. And wait approval. Note, for documentation changes you don't need approval during RDP1.

Sorry for the confusing and thanks @vnkozlov for jumping in and providing pointers to still get this into JDK 20. As Vladimir has mentioned, a flag renaming is an enhancement. But since it's low-risk, this should be easily approved for JDK 20.

@@ -238,7 +238,7 @@ const int ObjectAlignmentInBytes = 8;
product(bool, UseBASE64Intrinsics, false, \
"Use intrinsics for java.util.Base64") \
\
product(bool, UsePolyIntrinsics, false, DIAGNOSTIC, \
product(bool, UsePoly1305Intrinsics, false, DIAGNOSTIC, \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should fix the alignment of the \ here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thanks for spotting this

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just FTR, I think such flag renamings are non-trivial and therefore require two reviews before integration.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Dec 19, 2022
@vpaprotsk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@vpaprotsk
Your change (at version c31781b) is now ready to be sponsored by a Committer.

@vnkozlov
Copy link

This late enhancement request for JDK 20 was approved.

@sviswa7
Copy link

sviswa7 commented Dec 21, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

Going to push as commit 22007a1.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 9adc349: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
  • 81933b7: 8298642: ParallelGC -XX:+UseNUMA eden spaces allocated on wrong node
  • 92fe304: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body
  • f7be5b5: 8299156: Broken link in jdk.compiler/module-info.java
  • 3d4d9fd: 8298947: compiler/codecache/MHIntrinsicAllocFailureTest.java fails intermittently
  • e85d00f: 8299147: Minor accessibility errors in the specs and man index pages
  • f4d7f43: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus
  • 03afec1: 8298162: Test PrintClasses hits assert when run with code that retransform classes
  • 03d9927: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"
  • 65fc058: 8298968: G1: Incorrect merged remset stats
  • ... and 20 more: https://git.openjdk.org/jdk20/compare/ca39eb906692568347e7f264520593188f9276cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2022
@openjdk openjdk bot closed this Dec 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@sviswa7 @vpaprotsk Pushed as commit 22007a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
6 participants