Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 #50

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 16, 2022

A batch a trivial fixes to ProblemList tests:
JDK-8298976 ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
JDK-8298977 ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms
JDK-8298978 ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
  • JDK-8298977: ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms
  • JDK-8298978: ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/jdk20 pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/50.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8298976
/issue JDK-8298977
/issue JDK-8298978

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 16, 2022 21:04
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298977: ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms.

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298978: ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mlbridge
Copy link

mlbridge bot commented Dec 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
8298977: ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms
8298978: ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2022
@dcubed-ojdk
Copy link
Member Author

@kimbarrett - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

Going to push as commit 0ecad28.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c997b5b: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2022
@openjdk openjdk bot closed this Dec 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@dcubed-ojdk Pushed as commit 0ecad28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member Author

@irisclark - Thanks for the review! You may not be listed on the integration
depending on how the bots are running.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8298976 branch December 16, 2022 21:26
@AlanBateman
Copy link

Instead of excluding java/util/concurrent/ExecutorService/CloseTest.java, we can just comment out the line in the test's DataProvider that produces a ForkJoinPool. That will allow the t test to exercise the other implementations until ForkJoinPool shutdown issue is fixed.

@dcubed-ojdk
Copy link
Member Author

@AlanBateman - It's only ProblemListed on one platform...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants