Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero" #58

Closed
wants to merge 2 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Dec 19, 2022

Please review this limited fix to make symbol refcount not go to zero for the placeholder supername field. This supername field is to detect ClassCircularityError for parallel capable class loaders without deadlocking.
ie. t1 : Class A (lock object for A) -> super B (wait for lock object for B)
t2: Class B (lock object for B) -> super A (wait for lock object for A).

We get the supername field out of the placeholder table to do the check for super class CCE but the reference count in the placeholder table for this name can be one. The fix is not to decrement and increment if the name is the same.

Retesting with tier1-4 in progress.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/58/head:pull/58
$ git checkout pull/58

Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.org/jdk20 pull/58/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 58

View PR using the GUI difftool:
$ git pr show -t 58

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/58.diff

…a failed with "fatal error: refcount has gone to zero"
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 19, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2022

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ea40f29: 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepare Mixed): expected true, was false"
  • d0a7679: 4958969: ObjectOutputStream example leads to non-working code
  • f07acfc: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits
  • 3e17e3c: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus
  • 188aaef: 8277074: Qualified exported types show up in JavaDoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thanks.

@coleenp
Copy link
Contributor Author

coleenp commented Dec 20, 2022

Thanks for the reviews, Ioi and David.
/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

Going to push as commit 03d9927.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 65fc058: 8298968: G1: Incorrect merged remset stats
  • 3dd2cfa: 8298784: JFR: Test chunk integrity
  • ea40f29: 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepare Mixed): expected true, was false"
  • d0a7679: 4958969: ObjectOutputStream example leads to non-working code
  • f07acfc: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits
  • 3e17e3c: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus
  • 188aaef: 8277074: Qualified exported types show up in JavaDoc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2022
@openjdk openjdk bot closed this Dec 20, 2022
@coleenp coleenp deleted the symbol branch December 20, 2022 13:22
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@coleenp Pushed as commit 03d9927.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants