-
Notifications
You must be signed in to change notification settings - Fork 61
4958969: ObjectOutputStream example leads to non-working code #59
Conversation
Update example to use try-with-resources and use javadoc snippet tags.
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Roger, one trivial suggestion to consider below
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Roger.
/integrate |
Going to push as commit d0a7679.
Your commit was automatically rebased without conflicts. |
@RogerRiggs Pushed as commit d0a7679. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update javadoc examples to use try-with-resources and use javadoc snippet tags.
The examples in ObjectInputStream and ObjectOutputStream get an update with
try-with-resources and use of javadoc snippet tags.
ObjectInputFilter is updated with use of snippet tags instead of html markup.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/59/head:pull/59
$ git checkout pull/59
Update a local copy of the PR:
$ git checkout pull/59
$ git pull https://git.openjdk.org/jdk20 pull/59/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 59
View PR using the GUI difftool:
$ git pr show -t 59
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/59.diff