Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds #64

Closed
wants to merge 1 commit into from

Conversation

backwaterred
Copy link

@backwaterred backwaterred commented Dec 20, 2022

This change fixes an issue with a jck test described in JDK-8297275. The change applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.org/jdk20 pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/64.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5f63f7a742a1071a87ca69463bae6e04a44fe462 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@backwaterred The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

@backwaterred
Copy link
Author

All testing successful. Merging as per the issue comments.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

Going to push as commit 9adc349.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 81933b7: 8298642: ParallelGC -XX:+UseNUMA eden spaces allocated on wrong node
  • 92fe304: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body
  • f7be5b5: 8299156: Broken link in jdk.compiler/module-info.java
  • 3d4d9fd: 8298947: compiler/codecache/MHIntrinsicAllocFailureTest.java fails intermittently
  • e85d00f: 8299147: Minor accessibility errors in the specs and man index pages

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2022
@openjdk openjdk bot closed this Dec 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@backwaterred Pushed as commit 9adc349.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated nio nio-dev@openjdk.org
1 participant