Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8298455: JFR: Add logging to TestClose.java #7

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Dec 9, 2022

Hi,

Could I have a review of a test fix.

The test jdk/jfr/api/consumer/recordingstream/TestClose.java times out intermittently, but the thread dump looks fine. One possibility is that the onEvent action is never registered. It would be good to verify that the registration mechanism works properly. This can be done by logging with -Xlog:jfr+streaming+system=trace

Testing: running test locally

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/7/head:pull/7
$ git checkout pull/7

Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.org/jdk20 pull/7/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7

View PR using the GUI difftool:
$ git pr show -t 7

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/7.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@egahlin egahlin marked this pull request as ready for review December 9, 2022 09:56
@openjdk
Copy link

openjdk bot commented Dec 9, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-jfr hotspot-jfr-dev@openjdk.org rfr Pull request is ready for review labels Dec 9, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 9, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298455: JFR: Add logging to TestClose.java

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 133ad8e: 8297988: NPE in JavacTypes.getOverriddenMethods from doclint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2022
@openjdk
Copy link

openjdk bot commented Dec 9, 2022

Going to push as commit 5a92bee.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 133ad8e: 8297988: NPE in JavacTypes.getOverriddenMethods from doclint

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 9, 2022
@openjdk openjdk bot closed this Dec 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2022
@openjdk
Copy link

openjdk bot commented Dec 9, 2022

@egahlin Pushed as commit 5a92bee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants