This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
8298455: JFR: Add logging to TestClose.java #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Could I have a review of a test fix.
The test jdk/jfr/api/consumer/recordingstream/TestClose.java times out intermittently, but the thread dump looks fine. One possibility is that the onEvent action is never registered. It would be good to verify that the registration mechanism works properly. This can be done by logging with -Xlog:jfr+streaming+system=trace
Testing: running test locally
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/7/head:pull/7
$ git checkout pull/7
Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.org/jdk20 pull/7/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7
View PR using the GUI difftool:
$ git pr show -t 7
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/7.diff